feat: add support for aurelia 2 project detection #42
Conversation
|
Can we get some traction on this? |
| private fun hasDependency(project: Project): Boolean { | ||
| var hasDependency = false | ||
|
|
||
| VfsUtilCore.iterateChildrenRecursively(project.baseDir, null) { virtualFile -> |
There was a problem hiding this comment.
Vfs traversing is very expensive operation. Please check methods of com.intellij.javascript.nodejs.packageJson.PackageJsonFileManager, it provide high-level API to check package.json deps.
There was a problem hiding this comment.
this comment is still relevant. VFS processing can significantly degrade performance, especially for big projects.
There was a problem hiding this comment.
moreover, it looks like all usages of the method have a proper context psi element, so the best solution could be to traverse top to package.json and check its dependencies.
|
|
||
| patchPluginXml { | ||
| sinceBuild = "231.0" | ||
| untilBuild = "231.*" | ||
| untilBuild = "233.*" |
There was a problem hiding this comment.
no, we cannot sure that the plugin will be compatible with 233 version.
| @@ -8,14 +8,14 @@ repositories { | |||
| } | |||
|
|
|||
| intellij { | |||
| pluginName = 'AureliaStorm' | |||
| pluginName = 'AureliaStorm Community' | |||
There was a problem hiding this comment.
what's the reason to change plugin name?
|
sorry, I wrote a comment in May but looks like I didn't submit it as a part of review 🤦 |
|
|
||
| Either `aurelia-framework.js`, `aurelia-bootstrapper.js` or `aurelia-core.js` must be present in the project sources |
There was a problem hiding this comment.
also, we still need to keep old behaviour for very old projects.
Sorry if there is things missing, bad, etc. This is my first ever intellij plugin and I also have not written any Java/Kotlin in 10+
years.
This changes the following
Adds support for the following
I have confirmed this working on an aurelia 1 and aurelia 2 project. If I'm not mistaken these are the correct dependencies to check for.