-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/sqlite to enginev3 #3538
base: master
Are you sure you want to change the base?
chore/sqlite to enginev3 #3538
Conversation
let errors: IDendronError[] = []; | ||
let notesFname: NotePropsByFnameDict = {}; | ||
const start = process.hrtime(); | ||
const enableSQLITE = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DendronEngineV3
shouldn't be aware of anything related to SQLite - it should only know about the IDataStore
interface, otherwise we're losing the benefits we gained by creating those interfaces. We need to pull all init logic out of this class/file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if a user has the SQLite setting flipped in their configs and is using the web extension? wouldn't it cause problem at this point?
update: disregard. web implements a separate engine at this point. though this should probably move elsewhere like Jonathan mentioned to account for the eventual engine convergence.
FileStore is never used. But kept there for backwards compatibility until we clean it up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about the init process that @jonathanyeung
if I'm understanding it correctly, sqlite backend wouldn't work currently with the web extension unless we make it work in memory and in the browser. So I think it makes sense that this is tied to FileStorage
for the time being.
bf73fe4
to
69dac75
Compare
chore: enable sqlite for enginev3
engine.init
where error is always returned