Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(graphql): add n+1 test and fix a regression on champ siret #11290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tchak
Copy link
Member

@tchak tchak commented Feb 4, 2025

Loaders::Association.for contrairement à Loaders::Record.for n'override pas le travail fait par le DossierPreloader ou un includes

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.42%. Comparing base (54b5401) to head (3617aa8).

Files with missing lines Patch % Lines
app/graphql/types/champs/carte_champ_type.rb 0.00% 1 Missing ⚠️
app/graphql/types/dossier_type.rb 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11290      +/-   ##
==========================================
- Coverage   84.43%   84.42%   -0.01%     
==========================================
  Files        1211     1210       -1     
  Lines       26688    26667      -21     
  Branches     5038     5033       -5     
==========================================
- Hits        22533    22514      -19     
+ Misses       4155     4153       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant