Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ Usager, je veux qu'on supprime mon brouillon vide sur une démarche 2 semaine après l'avoir déposé #11170

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mmagn
Copy link
Contributor

@mmagn mmagn commented Dec 20, 2024

Fix #10950

Suppression des brouillons vides sans notification au préalable.

880K dossiers concernés en prod

@mmagn mmagn changed the title [#10950] Delete empty brouillons older than 2 weeks ETQ Usager, je veux qu'on supprime mon brouillon vide sur une démarche 2 semaine après l'avoir déposé Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (11dd700) to head (d576668).

Files with missing lines Patch % Lines
...n/never_touched_dossiers_brouillon_deletion_job.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11170      +/-   ##
==========================================
- Coverage   84.41%   84.40%   -0.01%     
==========================================
  Files        1199     1199              
  Lines       26378    26379       +1     
  Branches     4963     4964       +1     
==========================================
- Hits        22266    22265       -1     
- Misses       4112     4114       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmagn mmagn marked this pull request as ready for review January 9, 2025 09:54
@mmagn mmagn marked this pull request as draft January 14, 2025 16:33
@mmagn mmagn force-pushed the fix-10950 branch 8 times, most recently from 497173b to 04b3791 Compare January 21, 2025 16:41
@mmagn mmagn marked this pull request as ready for review January 21, 2025 17:32
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est ce que tu pourrais également supprimer le DossierEmptyConcern ?

Est ce qu'on est sur de vouloir shooter également les dossiers clonés ?

@@ -52,6 +56,12 @@ def send_termine_expiration_notices
)
end

def delete_never_touched_brouillons
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peut etre inliner cette méthode l7 ?

@mmagn
Copy link
Contributor Author

mmagn commented Jan 24, 2025

est ce que tu pourrais également supprimer le DossierEmptyConcern ?

C'est déjà fait il me semble

Est ce qu'on est sur de vouloir shooter également les dossiers clonés ?

On peut considérer qu'ils n'ont pas été créés involontairement et donc les exclure, ça me va.

@mmagn mmagn added this pull request to the merge queue Jan 24, 2025
@mmagn mmagn removed this pull request from the merge queue due to a manual request Jan 24, 2025
@mmagn mmagn marked this pull request as draft January 30, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETQ Usager, je veux qu'on supprime mon brouillon vide sur une démarche 2 semaine après l'avoir déposé
2 participants