Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusive & valid random share reserve range; dynamic fuzz bugfix #170

Merged
merged 7 commits into from
Jul 11, 2024

Conversation

dpaiton
Copy link
Member

@dpaiton dpaiton commented Jul 10, 2024

Description

  • share adjustment (zeta) was using a non-inclusive range, but the requirement (<=) implies inclusive should be valid.
    • I tested this with the bounds (share_adjustment = 0 and share_adjustment = share_reserves - min_share_reserves - fixed!(10e18)) and all tests passed with both extremes
    • note that I had to reduce the upper-bound by fixed!(10e18) for the tests to pass, which I guess means we were just getting lucky before. I made an issue for this: Tests fail when using large (but valid) share_adjustment #171
  • dynamic fuzz is supposed to do 10x fuzz runs on new tests, but was 1x with FAST_FUZZ_RUNS
  • fix a check in an open.rs test where the allowable max bond amount was too low

@dpaiton dpaiton changed the title inclusive & valid random share reserve range; dynamic fuzz bugfix Inclusive & valid random share reserve range; dynamic fuzz bugfix Jul 11, 2024
Copy link
Member

@ryangoree ryangoree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 (pending missing = commit)

@dpaiton dpaiton enabled auto-merge (squash) July 11, 2024 20:29
@dpaiton dpaiton merged commit c469d2b into main Jul 11, 2024
8 checks passed
@dpaiton dpaiton deleted the dpaiton/fuzz-fix branch July 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants