Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support announcing to all trackers of the same tier. #319

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Unit193
Copy link
Contributor

@Unit193 Unit193 commented Dec 17, 2021

@DjLegolas
Copy link
Contributor

Looks good.
Also, if you can, please add this to the WebUI (and console) as well.

@Unit193
Copy link
Contributor Author

Unit193 commented Dec 18, 2021

Ah yes, good plan. I haven't tested those of course, but I've been using this patch otherwise for quite some time.

@cas--
Copy link
Member

cas-- commented Jun 12, 2022

Can I just clarify what implementation we trying to achieve here with regards tracker announcing since there are two options:

announce_to_all_trackers

all trackers in the same tier are announced to in parallel. If all trackers in tier 0 fails, all trackers in tier 1 are announced as well.

announce_to_all_tiers

one tracker from each tier is announced to. This is the uTorrent behavior.

I have updated the Trac ticket with relevance discussion points but my take on this is to use the latter announce_to_all_tiers as per uT.

@@ -85,6 +85,7 @@
'max_active_downloading': 3,
'max_active_limit': 8,
'dont_count_slow_torrents': False,
'announce_to_all_trackers': True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should default to False

@Unit193
Copy link
Contributor Author

Unit193 commented Jun 12, 2022

I'd have gone for the former, it makes a lot more sense to me as you can configure exactly which trackers are fallback, and makes more logical sense to treat trackers set as the same priority in the list, well, the same.

It seems they're taking an entirely different definition to the tiers though, which if selecting this option would surprise me as a user as I'd have different expectations. Perhaps a mouseover if the latter is used?

@Unit193
Copy link
Contributor Author

Unit193 commented Jul 20, 2022

@cas-- I'm not specifically attached to the one way of doing this, I do have a preference but in the end either way will allow me to do what I want (without locally patching.) If you have wording suggestions for mouseover text or whatnot, that'd be appreciated too (unless you want to just adapt it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants