feat: generate 144-bit group IDs #5986
Merged
+20
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
reviewed
Sep 20, 2024
src/tools.rs
Outdated
| /// IDs generated by this function are 66 bit wide and are returned as 11 base64 characters. | ||
| /// The generated ID should be short but unique: | ||
| /// - short, because it used in Message-ID and Chat-Group-ID headers and in QR codes | ||
| /// - unique as two IDs generated on two devices should not be the same. However, collisions are not world-wide but only by the few contacts. |
There was a problem hiding this comment.
The second sentence is a bit hard to understand. Probably it's meant that we don't protect from collisions globally, but only at account and chat scale.
There was a problem hiding this comment.
Yes, makes no sense, I think I will remove it.
iequidoo
reviewed
Sep 20, 2024
| @@ -961,7 +957,6 @@ DKIM Results: Passed=true"; | |||
| #[test] | |||
| fn test_create_outgoing_rfc724_mid() { | |||
| let mid = create_outgoing_rfc724_mid(); | |||
| assert!(mid.starts_with("Mr.")); | |||
There was a problem hiding this comment.
Maybe check the length at least?
iequidoo
approved these changes
Sep 20, 2024
Instead of generating 72 random bits and reducing them to 66 bits of Base64 characters, generate 144 bits (18 bytes) which is exactly 24 Base64 characters. This should still be accepted by existing Delta Chat clients which expect group ID to be between 11 and 32 characters. Message-ID creation is also simplified to not have `Mr.` prefix and dot in between two IDs. Now it is a single ID followed by `@localhost`. Some outdated documentation comments are removed, e.g. group messages don't start with `Gr.` already.
link2xt
force-pushed
the
link2xt/message-id
branch
from
7fadd33
to
8357662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating 72 random bits
and reducing them to 66 bits of Base64 characters, generate 144 bits (18 bytes)
which is exactly 24 Base64 characters.
This should still be accepted by existing
Delta Chat clients which expect group ID
to be between 11 and 32 characters.
Message-ID creation is also simplified
to not have
Mr.prefixand dot in between two IDs.
Now it is a single ID followed by
@localhost.Some outdated documentation comments
are removed, e.g. group messages
don't start with
Gr.already.