[Spark] Handle case when Checkpoints.findLastCompleteCheckpoint is passed MAX_VALUE #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakharjain09
force-pushed
the
fixFindLastCompleteCheckpointBefore-2
branch
from
f95b428
to
2d51f80
Compare
prakharjain09
commented
May 17, 2024
Comment on lines
+458
to
+461
| // If someone passes the upperBound as 0 or sentinel value, we should not do backward | ||
| // listing. Instead we should list the entire directory from 0 and return the latest | ||
| // available checkpoint. | ||
| .filterNot(cv => cv.version < 0 || cv.version == CheckpointInstance.MaxValue.version) |
There was a problem hiding this comment.
This is the fix and there is a corresponding test: findLastCompleteCheckpoint with CheckpointInstance.MAX value .
scovich
approved these changes
May 17, 2024
Comment on lines
+149
to
+150
| assert(eventData1("iterations") == "1") | ||
| assert(eventData1("numFilesScanned") == "1004") |
There was a problem hiding this comment.
Does this work for better error messages?
Suggested change
| assert(eventData1("iterations") == "1") | |
| assert(eventData1("numFilesScanned") == "1004") | |
| assert(eventData1("iterations") === "1") | |
| assert(eventData1("numFilesScanned") === "1004") |
(bunch of others, including existing code... maybe worth a cleanup PR some day)
There was a problem hiding this comment.
For consistency in the test suite, I am keeping these as ==. Will open a PR which converts all == to ===.
tdas
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Fixes an issue where
Checkpoints.findLastCompleteCheckpointgoes into an almost infinite loop if it is passed a Checkpoint.MAX_VALUE.How was this patch tested?
UT
Does this PR introduce any user-facing changes?
No