[Spark] Metadata Cleanup for Unbackfilled Delta Files #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeet-db
force-pushed
the
metadata_normal
branch
4 times, most recently
from
51c4853
to
619cd42
Compare
sumeet-db
force-pushed
the
metadata_normal
branch
from
619cd42
to
8f5eac7
Compare
LukasRupprecht
approved these changes
May 22, 2024
| expiredDeltaLogs.map(_.getPath).foreach { path => | ||
| // recursive = false | ||
| if (fs.delete(path, false)) { | ||
| numDeleted += 1 | ||
| if (FileNames.isCheckpointFile(path)) { | ||
| wasCheckpointDeleted = true | ||
| } | ||
| if (FileNames.isDeltaFile(path)) { | ||
| maxBackfilledVersionDeleted = | ||
| Math.max(maxBackfilledVersionDeleted, FileNames.deltaVersion(path)) |
There was a problem hiding this comment.
Why do we need the max here? Shouldn't files be deleted in order?
There was a problem hiding this comment.
Ideally yes. But we're being defensive here.
longvu-db
pushed a commit
to longvu-db/delta
that referenced
this pull request
May 28, 2024
#### Which Delta project/connector is this regarding? - [x] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description Unbackfilled deltas eligible for deletion: - Version <= max(backfilled-delta-deleted-versions) ## How was this patch tested? Unit tests ## Does this PR introduce _any_ user-facing changes? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Unbackfilled deltas eligible for deletion:
How was this patch tested?
Unit tests
Does this PR introduce any user-facing changes?
No