-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slurm changes for omnia 2.0 #2479
Open
jagadeeshnv
wants to merge
31
commits into
dell:pub/new_architecture
Choose a base branch
from
jagadeeshnv:pub/new_architecture
base: pub/new_architecture
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
896a6c2
Slurm in a single role
jagadeeshnv f01658e
Lint fixes
jagadeeshnv 977f880
Clean up flag reset
jagadeeshnv 80ff376
Remove unused
jagadeeshnv f9244a8
pytorch python version fix
jagadeeshnv 4680b9e
[OMN01B-171]: Install slurmdbd with existing database
Cypher-Miller d8f04d9
[OMN01B-171]: Uncommented K8 code
Cypher-Miller 05e8b27
[OMN01B-208]: Add slurm ansible code to create new DB if
Cypher-Miller 3ba242b
[OMN01B-208]: Conditional added to only add db when db_host is provided
Cypher-Miller 6136805
Add node complete
jagadeeshnv b414b25
Dbd code uncommented
jagadeeshnv b673280
Remove Node done
jagadeeshnv 2e2a860
Add node fixed scontrol error
jagadeeshnv 55e1646
Moved db.yml task entry point, added default behavior for db_port and…
Cypher-Miller 66fad29
Merge branch 'pub/new_architecture' of github.com:jagadeeshnv/omnia i…
Cypher-Miller 4ec9c79
Updated some slurm var descriptions
Cypher-Miller a2a0be7
Cleanup of _config_files.yml
jagadeeshnv 6fd0a03
Cleanup of cleanll
jagadeeshnv 9a28e22
Share dir creation synchronized
jagadeeshnv a2e6c8c
Debug statements cleaned
jagadeeshnv 9e00ce9
Fixed Add db user tasks to successfully connect to mariadb db
Cypher-Miller c16d6d2
Merge branch 'pub/new_architecture' of github.com:jagadeeshnv/omnia i…
Cypher-Miller fe9355f
Added create new db user; Moved slurmdbd.conf creation code
Cypher-Miller 9e70e82
Fixed typo causing error when creating slurmdbd.conf
Cypher-Miller 9fb669a
benchmark tools openmpi command simplified
jagadeeshnv 7d433fe
Changed db_ to slurm_db_; Made slurmdbd db user's privileges more ris…
Cypher-Miller 358ecc2
Merge branch 'pub/new_architecture' of github.com:jagadeeshnv/omnia i…
Cypher-Miller bf73c31
Added support for db ports other than 3306
Cypher-Miller a30ec2c
Fixed issue where slurmctld service would sometimes not restart when …
Cypher-Miller e387f57
Reverted restart logic for slurmdbd and slurmctld
Cypher-Miller 5376453
additional check for specific slurmd restarts
jagadeeshnv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"openmpi": { | ||
"cluster": [ | ||
{ "package": "openmpi", | ||
"type": "tarball", | ||
"url": "https://download.open-mpi.org/release/open-mpi/v{{ openmpi_version.split('.')[:2] | join('.') }}/openmpi-{{ openmpi_version }}.tar.gz" | ||
}, | ||
{"package": "gcc-c++", "type": "rpm", "repo_name": "appstream"}, | ||
{"package": "clang", "type": "rpm", "repo_name": "appstream"} | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
{ | ||
"slurm": { | ||
"cluster": [ | ||
{"package": "munge", "type": "rpm", "repo_name": "appstream"}, | ||
{"package": "firewalld", "type": "rpm", "repo_name": "baseos"}, | ||
{"package": "python3-firewall", "type": "rpm", "repo_name": "baseos"} | ||
] | ||
}, | ||
"slurm_control_node": { | ||
"cluster": [ | ||
{"package": "slurm-slurmctld", "type": "rpm", "repo_name": "epel"} | ||
] | ||
}, | ||
"slurm_node": { | ||
"cluster": [ | ||
{"package": "slurm-slurmd", "type": "rpm", "repo_name": "epel"} | ||
] | ||
}, | ||
"slurmdbd":{ | ||
"cluster": [ | ||
{"package": "slurm-slurmdbd", "type": "rpm", "repo_name": "epel"}, | ||
{"package": "python3-PyMySQL", "type": "rpm", "repo_name": "appstream"}, | ||
{"package": "mysql-server", "type": "rpm", "repo_name": "appstream"}, | ||
{"package": "mariadb-server", "type": "rpm", "repo_name": "appstream"} | ||
] | ||
}, | ||
"login":{ | ||
"cluster": [ | ||
{"package": "slurm", "type": "rpm", "repo_name": "epel"} | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"ucx": { | ||
"cluster": [ | ||
{ "package": "ucx", | ||
"type": "tarball", | ||
"url": "https://github.com/openucx/ucx/releases/download/v{{ ucx_version }}/ucx-{{ ucx_version }}.tar.gz" | ||
}, | ||
{"package": "gcc-c++", "type": "rpm", "repo_name": "appstream"} | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
--- | ||
- name: Add nodes Slurm | ||
hosts: slurm_control_node, slurm_node, login, slurm_dbd | ||
any_errors_fatal: true | ||
vars: | ||
share_mounted_path: "{{ hostvars['localhost']['share_path'] | default('/home') }}" # from storage.yml | ||
#TODO: nfs_client role here, slurm depends on a mandatory share path | ||
pre_tasks: | ||
- name: Include input project directory | ||
ansible.builtin.import_role: | ||
name: ../utils/roles/include_input_dir | ||
run_once: true | ||
delegate_to: localhost | ||
- name: Include vars omnia_config.yml | ||
ansible.builtin.include_vars: | ||
file: "{{ input_project_dir }}/omnia_config.yml" | ||
run_once: true | ||
delegate_to: localhost | ||
tasks: | ||
- name: Add node | ||
ansible.builtin.import_role: | ||
name: slurm | ||
tasks_from: add_node |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
--- | ||
- name: Remove nodes Slurm | ||
hosts: slurm_control_node, slurm_node | ||
any_errors_fatal: true | ||
vars: | ||
share_mounted_path: "{{ hostvars['localhost']['share_path'] | default('/home') }}" # from storage.yml | ||
#TODO: nfs_client role here, slurm depends on a mandatory share path | ||
pre_tasks: | ||
- name: Include input project directory | ||
ansible.builtin.import_role: | ||
name: ../utils/roles/include_input_dir | ||
run_once: true | ||
delegate_to: localhost | ||
- name: Include vars omnia_config.yml | ||
ansible.builtin.include_vars: | ||
file: "{{ input_project_dir }}/omnia_config.yml" | ||
run_once: true | ||
delegate_to: localhost | ||
tasks: | ||
- name: Remove node | ||
ansible.builtin.import_role: | ||
name: slurm | ||
tasks_from: rm_node |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 0 additions & 74 deletions
74
scheduler/roles/install_benchmarks_tools/tasks/openmpi_cmd_with_slurm.yml
This file was deleted.
Oops, something went wrong.
49 changes: 0 additions & 49 deletions
49
scheduler/roles/install_benchmarks_tools/tasks/openmpi_cmd_without_slurm.yml
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
--- | ||
# defaults file for slurm | ||
mpi: {} | ||
cgroup: {} | ||
__cgroup_default_config: | ||
CgroupPlugin: autodetect | ||
ConstrainCores: true | ||
ConstrainDevices: true | ||
ConstrainRAMSpace: true | ||
ConstrainSwapSpace: true | ||
__slurm_default_config: | ||
SlurmUser: "{{ slurm_user }}" | ||
SlurmctldPort: 6817 | ||
SlurmdPort: 6818 | ||
SrunPortRange: "60001-63000" | ||
StateSaveLocation: "/var/spool/state" | ||
SlurmdSpoolDir: "/var/spool/slurmd" | ||
ReturnToService: 2 | ||
SchedulerType: sched/backfill | ||
MpiDefault: None | ||
ProctrackType: proctrack/cgroup | ||
SelectType: select/linear | ||
SlurmctldLogFile: /var/log/slurmctld.log | ||
SlurmdLogFile: /var/log/slurmd.log | ||
SlurmctldPidFile: /var/run/slurmctld.pid | ||
SlurmdPidFile: /var/run/slurmd.pid | ||
AuthType: auth/munge | ||
CryptoType: crypto/munge | ||
SlurmctldTimeout: 120 | ||
SlurmdTimeout: 300 | ||
__slurm_dbd_default_config: | ||
AuthType: auth/munge | ||
LogFile: /var/log/slurmdbd.log | ||
PidFile: /var/run/slurmdbd.pid | ||
SlurmUser: "{{ slurm_user }}" | ||
StorageType: accounting_storage/mysql | ||
StorageLoc: slurm_acct_db |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
--- | ||
# handlers file for slurm | ||
- name: Restart chrony | ||
ansible.builtin.systemd_service: | ||
name: "{{ 'chronyd' if ansible_os_family == 'RedHat' else 'chrony' }}" | ||
state: restarted | ||
enabled: true | ||
|
||
- name: Restart munge | ||
ansible.builtin.systemd_service: | ||
name: munge | ||
state: restarted | ||
|
||
- name: Restart mysqld | ||
ansible.builtin.systemd_service: | ||
name: mysqld | ||
state: restarted | ||
run_once: true | ||
when: restart_slurm_services | ||
delegate_to: "{{ slurm_db_host }}" | ||
|
||
- name: Restart mariadb | ||
ansible.builtin.systemd_service: | ||
name: mariadb | ||
state: restarted | ||
run_once: true | ||
when: restart_slurm_services | ||
delegate_to: "{{ slurm_db_host }}" | ||
|
||
- name: Reload slurmdbd | ||
ansible.builtin.systemd_service: | ||
name: slurmdbd | ||
state: reloaded | ||
daemon_reload: true | ||
enabled: true | ||
when: restart_slurm_services and ('slurm_dbd' in group_names) | ||
|
||
- name: Restart slurmdbd | ||
ansible.builtin.systemd_service: | ||
name: slurmdbd | ||
state: restarted | ||
when: restart_slurm_services and ('slurm_dbd' in group_names) | ||
|
||
- name: Reload slurmctld | ||
ansible.builtin.systemd_service: | ||
name: slurmctld | ||
state: reloaded | ||
daemon_reload: true | ||
enabled: true | ||
when: restart_slurm_services and ('slurm_control_node' in group_names) | ||
|
||
- name: Restart slurmctld | ||
ansible.builtin.systemd_service: | ||
name: slurmctld | ||
state: restarted | ||
when: restart_slurm_services and ('slurm_control_node' in group_names) | ||
|
||
- name: Reload slurmd | ||
ansible.builtin.systemd_service: | ||
name: slurmd | ||
state: reloaded | ||
daemon_reload: true | ||
enabled: true | ||
when: restart_slurm_services and ('slurm_node' in group_names) | ||
|
||
- name: Restart slurmd | ||
ansible.builtin.systemd_service: | ||
name: slurmd | ||
state: restarted | ||
when: restart_slurm_services and ('slurm_node' in group_names) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are having separate utility for remove node, we should handle there