Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Debug Flags Support #907

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

ChristianAtDell
Copy link
Contributor

Description

Extending from #905 per stakeholder asks. Additional flags are being supported.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1762

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Following the testing strategy from #905 , flags will be tested with each platform to ensure that they pass through from their installation as expected. TBD.

@ChristianAtDell ChristianAtDell changed the title Pub/add library debug flags Additional Debug Flags Support Feb 28, 2025
Copy link

github-actions bot commented Mar 3, 2025

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csm-operator/pkg/drivers 96.91% (+0.10%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csm-operator/pkg/drivers/powerflex.go 94.15% (+0.15%) 205 (+5) 193 (+5) 12 👍
github.com/dell/csm-operator/pkg/drivers/powerscale.go 100.00% (ø) 89 (+7) 89 (+7) 0
github.com/dell/csm-operator/pkg/drivers/powerstore.go 100.00% (ø) 71 (+7) 71 (+7) 0
github.com/dell/csm-operator/pkg/drivers/unity.go 98.18% (+0.22%) 110 (+12) 108 (+12) 2 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csm-operator/pkg/drivers/powerflex_test.go
  • github.com/dell/csm-operator/pkg/drivers/powerscale_test.go
  • github.com/dell/csm-operator/pkg/drivers/powerstore_test.go
  • github.com/dell/csm-operator/pkg/drivers/unity_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants