Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split long lines in domains.txt (revised) #662

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

redneck-f25
Copy link

@redneck-f25 redneck-f25 commented Aug 16, 2019

According to your comment (#642 (comment)) I revised my modifications.

There is a script to test the parsing of domains.txt at https://gist.github.com/redneck-f25/51ba79d0d3ef8a43a2eacffb672fd9d2.

Since many NAS- and Administration-Systems (e.g. Synology Diskstation and Plesk) have a plugin for LE for "simple" configurations it is the task of Dehydrated (which is great, btw) to handle more comlicated situations.

Thanks for your great work.

# example domains.txt
draft.example.com alias.example.com
draft1.example.com\
alias1.draft1.example.com\
# disabled: alias2.draft1.example.com\
alias3.draft1.example.com\

draft2.example.com \
  alias1.draft2.example.com \
  alias2.draft2.example.com \
  # disabled: alias3.draft2.example.com
draft3.example.com                  \
  alias1.draft3.example.com      \
  alias2.draft3.example.com      \
  # disabled: alias3.draft3.example.com
# end of domains.txt

@redneck-f25
Copy link
Author

@mrhackcz
Copy link

Hi. Very usefull feature. Can you please add this to next release ? @lukas2511

I think it can be much easier with just changing line 1675 from:

_sed -e 's/^[[:space:]]*//g' -e 's/[[:space:]]*$//g' -e 's/[[:space:]]+/ /g' -e 's/([^ ])>/\1 >/g' -e 's/> />/g' |

to

_sed -e 's/^[[:space:]]*//g' -e 's/[[:space:]]*$//g' -e 's/[[:space:]]+/ /g' -e 's/([^ ])>/\1 >/g' -e ':a;N;$!ba;s/\\\n/ /g' -e 's/> />/g' |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants