Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using no color when writing custom vertex attribute for sprites #8853

Merged
merged 1 commit into from Apr 29, 2024

Conversation

Jhonnyg
Copy link
Contributor

@Jhonnyg Jhonnyg commented Apr 25, 2024

Fixed an issue where a sprite was using a material with a "color" semantic type that didn't get written to the vertex buffer.

Fixes #8790

@Jhonnyg Jhonnyg requested a review from JCash April 25, 2024 14:08
@Jhonnyg Jhonnyg added bug Something is not working as expected engine Issues related to the Defold engine graphics labels Apr 25, 2024
@Jhonnyg Jhonnyg merged commit 69de0ca into dev Apr 29, 2024
24 checks passed
@Jhonnyg Jhonnyg deleted the issue-8790-sprite-semantic-type-color-fix branch April 29, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected engine Issues related to the Defold engine graphics
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Custom vertex attribute default value is discarded if one of the field is changed
2 participants