Implement transpiler support #8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlaaad
force-pushed
the
DEF-8291
branch
2 times, most recently
from
35a435e
to
f15c09b
Compare
This changeset adds initial Bob and Editor support for plugins that transpile 3rd-party languages to Lua. Transpiler plugins need to implement an `ILuaTranspiler` interface. See [the Teal extension](https://github.com/defold/extension-teal) for reference implementation. Fixes #8291
vlaaad
commented
May 3, 2024
| (:require [clojure.string :as string] | ||
| [dynamo.graph :as g] | ||
| [editor.build-target :as bt] | ||
| (:require [dynamo.graph :as g] |
There was a problem hiding this comment.
I moved script compilation to a different file (script_compilation.clj)
| :modules preprocessed-modules | ||
| :proj-path (resource/proj-path resource)} | ||
| :deps preprocessed-go-prop-dep-build-targets | ||
| :dynamic-deps (mapv lua/lua-module->path preprocessed-modules)})])))))) |
There was a problem hiding this comment.
99% of the code in this file is taken from script.clj. There is a small behavior difference: module dependencies are now :dynamic-deps that only reference dependent file paths instead of including the dependent build targets.
Comment on lines
+673
to
+681
| (defn reload-plugins! [project touched-resources] | ||
| (g/with-auto-evaluation-context evaluation-context | ||
| (let [workspace (workspace project evaluation-context) | ||
| code-preprocessors (workspace/code-preprocessors workspace evaluation-context) | ||
| code-transpilers (code-transpilers project)] | ||
| (workspace/unpack-editor-plugins! workspace touched-resources) | ||
| (code.preprocessors/reload-lua-preprocessors! code-preprocessors workspace/class-loader) | ||
| (code.transpilers/reload-lua-transpilers! code-transpilers workspace workspace/class-loader) | ||
| (workspace/load-clojure-editor-plugins! workspace touched-resources)))) |
There was a problem hiding this comment.
I moved plugin reload from workspace to project because it's needed for transpilers.
Comment on lines
-106
to
-136
| (defn flatten-build-targets | ||
| "Breadth first traversal / collection of build-targets and their child :deps, | ||
| skipping seen targets identified by the :content-hash of each build-target." | ||
| ([build-targets] | ||
| (flatten-build-targets build-targets #{})) | ||
| ([build-targets seen-content-hashes] | ||
| (assert (set? seen-content-hashes)) | ||
| (loop [targets build-targets | ||
| queue [] | ||
| seen seen-content-hashes | ||
| result (transient [])] | ||
| (if-some [target (first targets)] | ||
| (let [content-hash (:content-hash target)] | ||
| (assert (bt/content-hash? content-hash) | ||
| (str "Build target has invalid content-hash: " | ||
| (resource/resource->proj-path (:resource target)))) | ||
| (if (contains? seen content-hash) | ||
| (recur (rest targets) | ||
| queue | ||
| seen | ||
| result) | ||
| (recur (rest targets) | ||
| (conj queue (flatten (:deps target))) | ||
| (conj seen content-hash) | ||
| (conj! result target)))) | ||
| (if-some [targets (first queue)] | ||
| (recur targets | ||
| (rest queue) | ||
| seen | ||
| result) | ||
| (persistent! result)))))) |
There was a problem hiding this comment.
Moved to editor/build.cj
matgis
requested changes
May 6, 2024
com.dynamo.cr/com.dynamo.cr.bob/src/com/defold/extension/pipeline/ILuaTranspiler.java
Show resolved
Hide resolved
com.dynamo.cr/com.dynamo.cr.bob/src/com/defold/extension/pipeline/ILuaTranspiler.java
Outdated
Show resolved
Hide resolved
com.dynamo.cr/com.dynamo.cr.bob/src/com/defold/extension/pipeline/ILuaTranspiler.java
Outdated
Show resolved
Hide resolved
com.dynamo.cr/com.dynamo.cr.bob/src/com/defold/extension/pipeline/ILuaTranspiler.java
Outdated
Show resolved
Hide resolved
com.dynamo.cr/com.dynamo.cr.bob/src/com/defold/extension/pipeline/ILuaTranspiler.java
Show resolved
Hide resolved
britzl
reviewed
May 7, 2024
britzl
previously approved these changes
May 7, 2024
vlaaad
commented
May 8, 2024
| :ddf-type AtlasProto$Atlas | ||
| :load-fn load-atlas | ||
| :icon atlas-icon | ||
| :icon-class :design |
There was a problem hiding this comment.
Mostly indentation, but also added :icon-class
| :ddf-type GameSystem$CollectionProxyDesc | ||
| :load-fn load-collection-proxy | ||
| :icon collection-proxy-icon | ||
| :icon-class :property |
| :load-fn load-collision-object | ||
| :sanitize-fn sanitize-collision-object | ||
| :icon collision-object-icon | ||
| :icon-class :design |
| (code-transpilers project) | ||
| node-id | ||
| (resource/proj-path resource))] | ||
| (cond-> load-tx-steps transpiler-tx-steps (concat transpiler-tx-steps))) |
There was a problem hiding this comment.
After addressing your concerns, the performance looks like this:
| project size | total load time (ms) | transpiler overhead (ms) | decline (%) |
|---|---|---|---|
| small | 724.76 | 0.80 | 0.07% |
| big (without transpilers) | 179477.23 | 19.34 | 0.01% |
| big (with transpilers) | 174382.14 | 27.21 | 0.02% |
I think this is fine!
matgis
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds initial Bob and Editor support for plugins that transpile 3rd-party languages to Lua. Transpiler plugins need to implement an
ILuaTranspilerinterface. See the Teal extension for reference implementation.Fixes #8291