New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate OSX to GLFW3+ #8348
base: dev
Are you sure you want to change the base?
Migrate OSX to GLFW3+ #8348
Conversation
static bool OpenGLIsSupported() | ||
{ | ||
return (glfwInit() == GL_TRUE); | ||
return true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we got this far, we already know we have opengl support
share/ext/glfw/build_glfw.sh
Outdated
CMAKE_FLAGS="-DGLFW_VULKAN_STATIC=OFF ${CMAKE_FLAGS}" | ||
|
||
CMAKE_FLAGS_VULKAN="-DGLFW_VULKAN_STATIC=ON" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We build two libraries, one with vulkan support and one without
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also why the packages are a lot bigger. Not sure if we can do anything about it since we want vulkan as opt-in/opt-out
We have removed our old modified GLFW version on OSX in favour of the latest publicly released GLFW 3.3.8 version. This will enable us to improve our desktop feature set, as well as help fix many legacy OS issues across the board.
Fixes #7970