-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove glfw from the engine builds #8296
Conversation
…o remove-glfw-from-build
…o remove-glfw-from-build
…o remove-glfw-from-build
…o remove-glfw-from-build
def package(self): | ||
cwd = '../../packages' | ||
target = "glfw-%s-%s.tar.gz" % (VERSION, self.options.platform) | ||
|
||
dirs = [] | ||
dirs_search = ['include', 'lib', 'sdk', 'share'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there might be better ways to package this, but the old / current way of packaging isn't working with latest waf afaik, so for now this works "good enough"
#define HID_MOUSE_BUTTON_6 GLFW_MOUSE_BUTTON_6 | ||
#define HID_MOUSE_BUTTON_7 GLFW_MOUSE_BUTTON_7 | ||
#define HID_MOUSE_BUTTON_8 GLFW_MOUSE_BUTTON_8 | ||
#define HID_SPECIAL_START 256 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
scripts/submodule.sh
Outdated
@@ -58,7 +58,7 @@ for i in $(seq 2 $#); do | |||
( | |||
cd "${DEFOLD_PATH}/engine/${_SUBMODULE}" | |||
waf install --platform="${1}" \ | |||
--prefix="${DYNAMO_HOME}" --skip-codesign --skip-tests --skip-build-tests --opt-level=0 | |||
--prefix="${DYNAMO_HOME}" --skip-codesign --skip-tests --skip-build-tests --opt-level=0 --with-vulkan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also consider removing "--with-vulkan" from the build scripts, and instead add "--with-opengl"
GLFW is no longer being built as part of our main engine build. Instead, the current GLFW version (modified 2.7) is now begin built and distributed as an external package. We have also removed GLFW from our SDK, which means that some extensions might potentially break. This is considered a bugfix instead of a breaking change, since the headers should never have been part of the SDK from the first place.
This is the second part of our ongoing task (#7970) of migrating the current GLFW version to the latest stable official release, as well as separating all non-desktop platforms our of the GLFW infrastructure.
PR checklist
Example of a well written PR description:
### Technical changes
Technical changes:
Technical notes: