Tilemap editor plugins #7665
Draft
Tilemap editor plugins #7665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britzl
commented
May 20, 2023
| @@ -0,0 +1,13 @@ | |||
| package com.defold.extension.editor; | |||
There was a problem hiding this comment.
Questionable if the interface for editor plugins should be located here in bob?
britzl
commented
Jun 21, 2023
| (dissoc! cell-map (cell-index x y)))) | ||
| [cell-map layer-id x y tile h-flip v-flip rotate90] | ||
| ; figure out where to best do this once | ||
| (TilemapPlugins/init workspace/class-loader) |
There was a problem hiding this comment.
Initialising every frame is ofc not necessary. The question is where to put this line of code?
britzl
commented
Jun 21, 2023
| @@ -45,13 +54,14 @@ public class PluginScanner { | |||
| * This function will generate a CompileExceptionError if more than one | |||
| * class in the package path extends the same base class. | |||
| * | |||
| * @param scanner | |||
There was a problem hiding this comment.
Need to be able to pass classloader scanner from the editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a plugin system for the tilemap editor, where plugins can hook into the paint and clear tile functionality of the tilemap editor. Plugins will be notified when a tile is painted or cleared and the plugin can return a list of additional tiles which should be changed based on the change to the tilemap. This can be used to implement auto tiling and similar functionality.
PR checklist