Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid texture profile configuration #6579

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

britzl
Copy link
Contributor

@britzl britzl commented May 5, 2022

With the introduction of Basis Universal texture compression came changes to how we compress and handle textures in our build pipeline and at runtime. Previously we let the developer explicitly decide which compressed format to use through our texture profile system. This workflow is no longer supported and with this fix we have made the last couple of changes both to our build pipeline and editor to handle existing invalid texture profile configurations and to prevent the user from selecting formats which we no longer support.

Fixes #6377

@britzl britzl marked this pull request as draft May 5, 2022 09:01
@britzl
Copy link
Contributor Author

britzl commented May 13, 2022

This PR requires some additional work in the editor to improve how the texture profiles are set up. It should only be possible to set up one type+format+compression-level per profile+platform combo. It is currently possible to set up more than one. This should be prohibited. Also it would make sense to let the user first pick Type (None or basis_uastc), then format (rgb, rgba, luminance etc) and then finally compress level (fast, best etc).

Screenshot 2022-05-13 at 11 32 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Texture profiles, Rgba etc2 - errors on startup
2 participants