Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvements #150

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Usability improvements #150

merged 1 commit into from
Jun 3, 2024

Conversation

wongjingping
Copy link
Collaborator

  • api server to not print prompt token ids
  • postpone imports in dialects.py to avoid importing unless we're using the specific db_type and actually triggering the validity checks

@wongjingping wongjingping requested a review from rishsriv May 31, 2024 10:26
postpone imports in dialects.py
@rishsriv
Copy link
Member

rishsriv commented Jun 3, 2024

Thank you for these fixes!

@rishsriv rishsriv merged commit b8b7704 into main Jun 3, 2024
2 checks passed
@rishsriv rishsriv deleted the jp/api_eval branch June 3, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants