chore: add relay handler #239

hexshire · 2025-01-30T23:39:21Z

Closes OPT-600

linear · 2025-01-30T23:39:23Z

coderabbitai · 2025-01-30T23:39:28Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

packages/contracts-bedrock/test/invariants/interop/helpers/Handler.sol

0xDiscotech · 2025-01-31T16:01:48Z

packages/contracts-bedrock/test/invariants/interop/helpers/Handler.sol

+            0,
+            abi.encodeWithSelector(L2_TO_L2_MESSENGER.relayMessage.selector, _id, sentMessage)
+        );
+        if (success) {


Here missing an increase on the _ghost_superWethBalancesSum variable:

Increases if sending to SUPER_WETH as target with value greater than 0

increases if calling SUPER_WETH#crosschainMint

Decreases if withdrawing or calling SUPERWETH#crosschainBurn

Also, _ghost_superWethEtherSent will need to be increased only if SUPER_WETH#relayETH is called and the _to address is the same SUPER_WETH address.

…dler.sol Co-authored-by: Disco <[email protected]>

0xDiscotech · 2025-01-31T16:21:05Z

packages/contracts-bedrock/test/invariants/interop/helpers/Handler.sol

+        // Check the Ether balances and that the superchain WETH total supply was not modified
+        assert(actor.ethBalance() == actorBalanceBefore - _value);


Let's add a blank space here between the call with its assert success, and the rest of assertions

chore: add relay handler

a9cf559

hexshire requested a review from 0xDiscotech January 30, 2025 23:39

hexshire self-assigned this Jan 30, 2025

hexshire added 2 commits January 30, 2025 20:41

chore: check l1 contract is not target

10b5f3c

chore: refactor pre condition

015f900

hexshire marked this pull request as ready for review January 31, 2025 12:10

hexshire added 2 commits January 31, 2025 09:49

fix: wrong pre condition

fbdfaa4

chore: fix conditions

fa0ba72

0xDiscotech reviewed Jan 31, 2025

View reviewed changes

Update packages/contracts-bedrock/test/invariants/interop/helpers/Han…

3a9f7e6

…dler.sol Co-authored-by: Disco <[email protected]>

0xDiscotech reviewed Jan 31, 2025

View reviewed changes

chore: add value to relay

3a0871d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add relay handler #239

chore: add relay handler #239

hexshire commented Jan 30, 2025

linear bot commented Jan 30, 2025

coderabbitai bot commented Jan 30, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

0xDiscotech Jan 31, 2025

0xDiscotech Jan 31, 2025

		// Check the Ether balances and that the superchain WETH total supply was not modified
		assert(actor.ethBalance() == actorBalanceBefore - _value);

chore: add relay handler #239

Are you sure you want to change the base?

chore: add relay handler #239

Conversation

hexshire commented Jan 30, 2025

linear bot commented Jan 30, 2025

coderabbitai bot commented Jan 30, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

0xDiscotech Jan 31, 2025

Choose a reason for hiding this comment

0xDiscotech Jan 31, 2025

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)