feat:l2 proxy admin #233
Merged
feat:l2 proxy admin #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusduha
requested changes
Feb 4, 2025
There was a problem hiding this comment.
I believe that there are missing changes at L2Genesis, the L2ProxyAdmin is not being deployed right now as far as i can see (maybe im wrong) and we don't have a test to be sure about it.
Also the L2Genesis.s.sol has an owner slot override when deploying the admin that should not be there anymore
| // Constants | ||
| import { Constants } from "src/libraries/Constants.sol"; | ||
|
|
||
| contract L2ProxyAdmin_Test is Test { |
There was a problem hiding this comment.
The only problem im seeing here is that we are not really testing the the L2ProxyAdmin is integrated
For this we usually use CommonTest that setups the L2
agusduha
reviewed
Feb 6, 2025
| address impl = _setImplementationCode(Predeploys.PROXY_ADMIN); | ||
|
|
||
| bytes32 _ownerSlot = bytes32(0); | ||
|
|
||
| // there is no initialize() function, so we just set the storage manually. | ||
| vm.store(Predeploys.PROXY_ADMIN, _ownerSlot, bytes32(uint256(uint160(cfg.proxyAdminOwner())))); | ||
| // update the proxy to not be uninitialized (although not standard initialize pattern) | ||
| vm.store(impl, _ownerSlot, bytes32(uint256(uint160(cfg.proxyAdminOwner())))); | ||
| _setImplementationCode(Predeploys.PROXY_ADMIN); |
There was a problem hiding this comment.
This is good! The old PR initialized the slot with a dead address tho, are we sure there is no risk having the slot not initialized?
agusduha
approved these changes
Feb 6, 2025
0xOneTony
reviewed
Feb 6, 2025
0xOneTony
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPT-635