Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: injector and init package reference material #2468

Merged
merged 15 commits into from May 14, 2024
Merged

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Apr 30, 2024

Description

  • Finally start documenting the injector
  • Update init package docs
  • Consolidate init package reference material into single page, bring it out of FAQ

Checklist before merging

Signed-off-by: razzle <[email protected]>
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit bc11cea
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66423b6f7820d800087314d4

@Noxsios
Copy link
Contributor Author

Noxsios commented May 10, 2024

Commenting the preview URL because netlify overwrites its comment when it cancels the build (due to no changes)

https://deploy-preview-2468--zarf-docs.netlify.app/

@Noxsios Noxsios changed the title docs: update and fully flesh out init package docs: injector and init package reference material May 10, 2024
@Noxsios Noxsios marked this pull request as ready for review May 10, 2024 06:54
@Noxsios Noxsios requested a review from a team as a code owner May 10, 2024 06:54
Signed-off-by: razzle <[email protected]>
Copy link
Member

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Few minor comments

site/src/content/docs/ref/init-package.mdx Outdated Show resolved Hide resolved
site/src/content/docs/ref/init-package.mdx Outdated Show resolved Hide resolved
site/src/content/docs/ref/init-package.mdx Outdated Show resolved Hide resolved
site/src/content/docs/ref/init-package.mdx Show resolved Hide resolved
lucasrod16
lucasrod16 previously approved these changes May 10, 2024
Copy link
Member

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

site/src/content/docs/ref/init-package.mdx Outdated Show resolved Hide resolved
site/src/content/docs/ref/init-package.mdx Show resolved Hide resolved
site/src/content/docs/ref/init-package.mdx Outdated Show resolved Hide resolved
Signed-off-by: razzle <[email protected]>
@Noxsios Noxsios dismissed AustinAbro321’s stale review May 14, 2024 00:08

stale / issues mostly resolved, can always tweak later if need be, it is docs after all

@Noxsios Noxsios merged commit 488a9ad into main May 14, 2024
30 checks passed
@Noxsios Noxsios deleted the document-injector branch May 14, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants