update find-images output to contain the images' digest #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waveywaves
requested review from
jeff-mccoy,
Racer159,
Noxsios and
lucasrod16
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
AustinAbro321
requested changes
Mar 1, 2024
src/pkg/packager/prepare.go
Outdated
| imageWithSha, err := utils.GetImageWithSha(image) | ||
| if err != nil { | ||
| message.WarnErrf(err, "Problem getting image with sha for %s: %s", image, err.Error()) | ||
| erroredCosignLookups = append(erroredCosignLookups, image) |
There was a problem hiding this comment.
Cosign signatures are different than sha signatures. I recommend creating a new array for erroredShaLookups. You can place a message near erroredCosginLookups in the below block further down in the file
There was a problem hiding this comment.
added a check with erroredShaLookups
Co-authored-by: Austin Abro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update find-images output to contain the images' digest
Related Issue
Fixes #2247
Type of change
Checklist before merging