Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default-required feature flag #2211

Open
wants to merge 146 commits into
base: main
Choose a base branch
from
Open

feat: default-required feature flag #2211

wants to merge 146 commits into from

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Jan 2, 2024 •
edited

Description

Refer to adr/0025-required-optional.md.

Related Issue

Fixes #2059

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify Netlify
Copy link

netlify bot commented Jan 2, 2024 •
edited

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 7cc9973
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/664e34e81dc3e80008df876e

@Noxsios Noxsios added needs-docs PR Label - Docs required to merge needs-tests PR Label - Tests required to merge breaking-change 💔 labels Jan 2, 2024
@Noxsios
fix example
2a98254 
Signed-off-by: razzle <[email protected]>
@Noxsios
fix tests + examples
7b13799 
Signed-off-by: razzle <[email protected]>
@Noxsios

This comment was marked as resolved.

Sign in to view
@Noxsios
initial migration code
2ffd606 
Signed-off-by: razzle <[email protected]>
@Noxsios
add warning to migrate
d1d7258 
Signed-off-by: razzle <[email protected]>
@Noxsios
cleanup
d05c515 
Signed-off-by: razzle <[email protected]>
@Noxsios
cleanup
36bfdf4 
Signed-off-by: razzle <[email protected]>
@Noxsios Noxsios added the uds label Jan 2, 2024
@Noxsios Noxsios changed the title Required key --> Optional key (default is optional: false) feat: required key --> optional key Jan 2, 2024
@Noxsios Noxsios marked this pull request as ready for review January 3, 2024 02:58
@Noxsios Noxsios removed the needs-tests PR Label - Tests required to merge label May 10, 2024
@Noxsios Noxsios requested a review from dgershman as a code owner May 15, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasrod16 lucasrod16 lucasrod16 requested changes

@Racer159 Racer159 Racer159 requested changes

@AustinAbro321 AustinAbro321 AustinAbro321 requested changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@mike-winberry mike-winberry Awaiting requested review from mike-winberry

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

@dgershman dgershman Awaiting requested review from dgershman dgershman is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ready-for-review uds
Projects
No open projects
Zarf Project Board
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠ Breaking Change: make components required by default
4 participants
@Noxsios @Racer159 @AustinAbro321 @lucasrod16