Skip to content

Commit

Permalink
Fix: Failing Big Bang 2.0 Deployments (#1648)
Browse files Browse the repository at this point in the history
## Description

It appears that there is a mistake in the error handling of the
semver.NewVersion function. It should be checking for no error instead
of error. Found with @ragingpastry

## Related Issue

Fixes #
<!-- or -->
Relates to #

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: william.walker.102 <[email protected]>
  • Loading branch information
willswire and williamwalker102 committed Apr 25, 2023
1 parent af2db8d commit 9e3a63f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/extensions/bigbang/manifests.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func manifestZarfCredentials(version string) corev1.Secret {
values := bbV1ZarfCredentialsValues

semverVersion, err := semver.NewVersion(version)
if err != nil && semverVersion.Major() == 2 {
if err == nil && semverVersion.Major() == 2 {
values = bbV2ZarfCredentialsValues
}

Expand Down

0 comments on commit 9e3a63f

Please sign in to comment.