Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resolve max statement in watch-processor #1770

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: resolve max statement in watch-processor #1770

wants to merge 4 commits into from

Conversation

cmwylie19
Copy link
Contributor

Description

Reduce max-statements in watch-processor around watch. This PR depends on a KFC release

Related Issue

Fixes #1697

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner February 5, 2025 19:59
@cmwylie19 cmwylie19 mentioned this pull request Feb 5, 2025
Merged
5 tasks
github-merge-queue bot pushed a commit to defenseunicorns/kubernetes-fluent-client that referenced this pull request Feb 5, 2025
@cmwylie19
feat: expose watcher class types (#555)
90638e2 
## Description

This type is required for Pepr
[1770](defenseunicorns/pepr#1770) to reduce
complexity

## Related Issue

Fixes #

<!-- or -->

Relates to #[1770](defenseunicorns/pepr#1770) 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

Signed-off-by: Case Wylie <[email protected]>
@socket-security Socket Security
Copy link

socket-security bot commented Feb 5, 2025 •
edited
Loading

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] 🔁 npm/[email protected] Transitive: unsafe +96 49.1 MB pepr-dev

View full report↗︎

@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (29bd080) to head (1318875).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
+ Coverage   82.05%   82.11%   +0.06%     
==========================================
  Files          52       52              
  Lines        2212     2214       +2     
  Branches      470      436      -34     
==========================================
+ Hits         1815     1818       +3     
- Misses        368      394      +26     
+ Partials       29        2      -27
Files with missing lines Coverage Δ
src/lib/processors/watch-processor.ts 79.24% <100.00%> (+1.36%) ⬆️
src/lib/telemetry/metrics.ts 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

samayer12
samayer12 previously approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, left two comments that I'd like to consider but aren't worth holding up the PR over (i.e., we can always revisit them later).

@cmwylie19 cmwylie19 enabled auto-merge February 5, 2025 21:13
@samayer12 samayer12 mentioned this pull request Feb 5, 2025
Open
@cmwylie19 cmwylie19 disabled auto-merge February 6, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samayer12 samayer12 samayer12 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Pepr Project Board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve max-statements warning in src/lib/processors/watch-processor.ts
2 participants
@cmwylie19 @samayer12