fix pretrain gpt and llama bug #476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuanhuaWang
requested changes
May 12, 2025
| @@ -1654,7 +1654,7 @@ def get_num_experts_per_layer(num_experts: list, num_layers: int, expert_interva | |||
| num_experts = num_experts * (num_layers // expert_interval) | |||
| experts_per_layer = [] | |||
| for i in range(num_layers): | |||
| layer_num = i + 1 + offset | |||
There was a problem hiding this comment.
Hi, why do we need to delete this offset ?
There was a problem hiding this comment.
This would cause num_experts to go out of bounds
See this issue for details: issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some issues when running gpt and llama pre-training