feat(fetcher): custom request headers for LinkContentFetcher #9756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Feature
request_headers: dict[str, str] = {}
toLinkContentFetcher
.REQUEST_HEADERS
)request_headers
(new)User-Agent
(rotation wins; keeps UA rotation behavior intact)Resilience
http2=True
buth2
is not installed, log a warning and gracefully fall back to HTTP/1.1 (avoid raisingImportError
).Docs
How did you test it?
test/components/fetchers/test_link_content_fetcher.py
):TestLinkContentFetcher_CustomHeaders::test_request_headers_sync_merging_and_ua_override
TestLinkContentFetcherAsync_CustomHeaders::test_request_headers_async_merging_and_ua_override
User-Agent
overrides any UA supplied viarequest_headers
.-m "not integration"
): all green.Notes for the reviewer
request_headers
is provided.Checklist
feat: