Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding missing component decorator to AzureOpenAIGenerator #7698

Merged
merged 4 commits into from
May 15, 2024
Merged

fix: Adding missing component decorator to AzureOpenAIGenerator #7698

merged 4 commits into from
May 15, 2024

Conversation

davidsbatista
Copy link
Contributor

Related Issues

Proposed Changes:

  • adding the missing @component decorator

How did you test it?

  • run all unit and integration tests

@coveralls
Copy link
Collaborator

coveralls commented May 14, 2024 •
edited

Pull Request Test Coverage Report for Build 9086515970

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 90.6%
Files with Coverage Reduction New Missed Lines %
components/generators/azure.py 2 92.11%
components/generators/chat/azure.py 2 91.89%
core/pipeline/pipeline.py 3 98.01%
core/pipeline/base.py 16 92.72%
Totals Coverage Status
Change from base Build 9081766626: 0.2%
Covered Lines: 6564
Relevant Lines: 7245
💛 - Coveralls

@davidsbatista davidsbatista marked this pull request as ready for review May 14, 2024 18:21
@davidsbatista davidsbatista requested review from a team as code owners May 14, 2024 18:21
@davidsbatista davidsbatista requested review from dfokina and anakin87 and removed request for a team May 14, 2024 18:21
anakin87
anakin87 approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I left a minor comment.

test/components/generators/chat/test_azure.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the type:documentation Improvements on the docs label May 14, 2024
@davidsbatista davidsbatista changed the title fix: serialization and deserialization of AzureGenerator fix: Adding missing component decorator to AzureOpenAIGenerator May 14, 2024
@davidsbatista davidsbatista added this to the 2.1.2 milestone May 14, 2024
@davidsbatista davidsbatista removed the type:documentation Improvements on the docs label May 14, 2024
@davidsbatista davidsbatista merged commit 96b9d3e into main May 15, 2024
27 checks passed
@davidsbatista davidsbatista deleted the fix-de-serialize-generators branch May 15, 2024 08:00
davidsbatista added a commit that referenced this pull request May 16, 2024
@davidsbatista
fix: Adding missing component decorator to AzureOpenAIGenerator (#7698
dfc243c 
)

* initial import

* adding release notes

* tests avoiding I/O operations

* Update fix-azure-generators-serialization-18fcdc9cbcb3732e.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci left review comments

@anakin87 anakin87 anakin87 approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

Deserialize - AzureOpenAIGenerator
4 participants
@davidsbatista @coveralls @masci @anakin87