Use aliases for response type references #1527
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses type aliases for response schema definitions.
While using a schema like:
I noticed that this generated "strict" server code that looked like:
However this doesn't actually work when doing the serialisation, because the type definition hides the definition of
MarshalJSON()
. Since theunion
field is private, this means the response that is actually serialised is{}
every time.Instead, we should just inherit that response from the referenced type definition. I.e. with
type GetExampleResponseObject = OneOrAnother
, the underlyingMarshalJSON
implementation will be picked up instead, and we can serialise the underlying union.