Merge pull request scikit-optimize#610 from betatim/categorical-repr

[MRG] Fix __repr__ for Categorical dimensions with many options
deephyper · Jan 22, 2018 · af08487 · af08487
2 parents 7295507 + be7593e
commit af08487
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/skopt/space/space.py b/skopt/space/space.py
@@ -442,7 +442,7 @@ def __eq__(self, other):
 
     def __repr__(self):
         if len(self.categories) > 7:
-            cats = self.categories[:3] + [_Ellipsis()] + self.categories[-3:]
+            cats = self.categories[:3] + (_Ellipsis(), ) + self.categories[-3:]
         else:
             cats = self.categories
 

diff --git a/skopt/tests/test_space.py b/skopt/tests/test_space.py
@@ -166,6 +166,17 @@ def test_categorical_transform_binary():
     assert_array_equal(ent_inverse, categories)
 
 
+@pytest.mark.fast_test
+def test_categorical_repr():
+    small_cat = Categorical([1, 2, 3, 4, 5])
+    assert (small_cat.__repr__() ==
+            "Categorical(categories=(1, 2, 3, 4, 5), prior=None)")
+
+    big_cat = Categorical([1, 2, 3, 4, 5, 6, 7, 8])
+    assert (big_cat.__repr__() ==
+            'Categorical(categories=(1, 2, 3, ..., 6, 7, 8), prior=None)')
+
+
 @pytest.mark.fast_test
 def test_space_consistency():
     # Reals (uniform)