Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elide unneeded lifetimes #105

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Elide unneeded lifetimes #105

merged 2 commits into from
Jan 24, 2025

Conversation

jcdyer
Copy link
Contributor

@jcdyer jcdyer commented Jan 24, 2025 •
edited
Loading

Fix some lints that have come in with new rust releases.

@jcdyer jcdyer requested review from bd-g and DamienDeepgram January 24, 2025 15:30
bd-g
bd-g approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@bd-g bd-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump our MSRV to clean up that CI?

@jcdyer
Copy link
Contributor Author

jcdyer commented Jan 24, 2025

No, it's the minimum serde version that needs updating.

@jcdyer
Copy link
Contributor Author

jcdyer commented Jan 24, 2025

Oh. I was behind origin/main, and it had already been (aggressively) updated.

@jcdyer jcdyer merged commit ca5e7e9 into main Jan 24, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bd-g bd-g bd-g approved these changes

@DamienDeepgram DamienDeepgram Awaiting requested review from DamienDeepgram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcdyer @bd-g