check to use the previous summary or not. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deep-diver
requested changes
Feb 23, 2025
app.py
Outdated
| response = await client.models.generate_content( | ||
| model=args.model, | ||
| contents=[ | ||
| Template( | ||
| prompt_tmpl['summarization']['prompt'] | ||
| ).safe_substitute( | ||
| previous_summary=state['summary'], | ||
| previous_summary=state['summary'] if use_generated_summaries else "No previous summary", |
There was a problem hiding this comment.
I don't think this line needs to be changed.
Instead, we need to change line number 61 because we want to see how the model's response changes based on the summary or the entire conversation.
|
@deep-diver can you give it a look again and test? Take your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deep-diver is this what you were envisioning?