fix(vmrestore): skip processing when snapshot secret name is empty

[loktev-d]

Description

Fix virtualMachineSnapshotSecret "" not found errors by skipping VMBDA processing when the snapshot secret name hasn't been populated yet.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

• The code is covered by unit tests.
• e2e tests passed.
• Documentation updated according to the changes.
• Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmrestore
type: fix 
summary: Remove spurious error logs when snapshot secret name is not yet populated during initialization.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an early check in the VM BDA watcher to skip processing snapshots without a populated secret name, preventing spurious errors during restore initialization.

Sequence diagram for VM BDA watcher processing with secret name check

sequenceDiagram
    participant VM_BDA_Watcher
    participant VM_Snapshot
    participant Secret
    VM_BDA_Watcher->>VM_Snapshot: Get Status.VirtualMachineSnapshotSecretName
    alt Secret name is empty
        VM_BDA_Watcher-->>VM_BDA_Watcher: Skip processing
    else Secret name is populated
        VM_BDA_Watcher->>Secret: Fetch Secret by name
        Secret-->>VM_BDA_Watcher: Return Secret or error
    end

Loading

Class diagram for VirtualMachineSnapshot status change

classDiagram
    class VirtualMachineSnapshot {
        Status: VirtualMachineSnapshotStatus
    }
    class VirtualMachineSnapshotStatus {
        VirtualMachineSnapshotSecretName: string
    }
    VirtualMachineSnapshot --> VirtualMachineSnapshotStatus: has
    class VirtualMachineBlockDeviceAttachmentWatcher {
        enqueueRequests(ctx, req)
    }
    VirtualMachineBlockDeviceAttachmentWatcher --> VirtualMachineSnapshot: reads Status.VirtualMachineSnapshotSecretName

Loading

File-Level Changes

Change	Details	Files
Skip processing VM snapshots when secret name is empty	Added conditional to check if VirtualMachineSnapshotSecretName is empty Continue the loop early to avoid fetching a non-existent Secret	images/virtualization-artifact/pkg/controller/vmrestore/internal/watcher/vmbda_watcher.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deckhouse-BOaTswain]

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.