Skip to content

Conversation

@yaroslavborbat
Copy link
Member

Description

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section:
type:
summary:

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates component versions to point to a new kubevirt feature branch for immediate toleration sync, adjusts the pod placement comparator to trigger a dynamic placementAction instead of a static restart when tolerations differ, and adds a temporary cache version entry in the werf configuration.

Class diagram for updated pod placement comparator logic

classDiagram
class VirtualMachineSpec {
  +Tolerations
}
class FieldChange {
  +currentValue
  +desiredValue
  +isEqual
  +action
}
class comparator_pod_placement {
  +compareTolerations(current: VirtualMachineSpec, desired: VirtualMachineSpec): FieldChange[]
}
VirtualMachineSpec --> comparator_pod_placement : used by
comparator_pod_placement --> FieldChange : returns
FieldChange : action
FieldChange : now set by placementAction() (was ActionRestart)
Loading

File-Level Changes

Change Details Files
Bump kubevirt to toleration-sync feature branch
  • Updated core.3p-kubevirt version to feat/sync-toleration-when-affinity-change-request
build/components/versions.yml
Switch to placementAction for toleration diffs
  • Replaced ActionRestart with placementAction() in the comparator logic
images/virtualization-artifact/pkg/controller/vmchange/comparator_pod_placement.go
Insert placeholder cache version in werf config
  • Added fromCacheVersion: 0000 with a TODO comment for cleanup
images/virt-artifact/werf.inc.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant