Skip to content

Conversation

@diafour
Copy link
Member

@diafour diafour commented Oct 21, 2025

Description

Change 3p-kubevirt to v1.3.1-v12n.19 tag.

Why do we need it, and what problem does it solve?

API server may return empty node without API error if there are problem with interaction between kube-apiserver and etcd.

Rare situation, but worth to fix.

deckhouse/3p-kubevirt#35

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: chore
summary: fix nil map panic when kube-apiserver is not healthy

API server may return empty node without API error if there are problem with interaction between kube-apiserver and etcd.

Rare situation, but worth to fix.

deckhouse/3p-kubevirt#35
Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour diafour added this to the v1.2.0 milestone Oct 21, 2025
@diafour diafour requested review from Isteb4k and fl64 as code owners October 21, 2025 13:48
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 21, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the 3p-kubevirt component version in build/components/versions.yml to v1.3.1-v12n.19, bringing in the nil map panic fix when the kube-apiserver is unhealthy.

File-Level Changes

Change Details Files
Bump 3p-kubevirt version to include nil map panic fix
  • Updated 3p-kubevirt tag from v1.3.1-v12n.17 to v1.3.1-v12n.19
build/components/versions.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

libvirt: v10.9.0
edk2: stable202411
core:
3p-kubevirt: v1.3.1-v12n.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be merged after #1569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants