EventsGet
#305
Merged
EventsGet
#305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistermoe
requested review from
csuwildcat,
diehuxx and
thehenrytsai
as code owners
Closed
Contributor
Author
|
added handler tests |
Contributor
thehenrytsai
left a comment
thehenrytsai
left a comment
There was a problem hiding this comment.
Looks pretty clean on DWN method implementation front, nothing much to say there! Have comments on MessageReply changes as you predicted.
dcrousso
previously approved these changes
Apr 14, 2023
diehuxx
previously approved these changes
Apr 15, 2023
diehuxx
left a comment
diehuxx
left a comment
There was a problem hiding this comment.
lgtm! thx for getting the changes in before Saturday, have a happy n healthy weekend :)
diehuxx
previously approved these changes
Apr 15, 2023
frankhinek
previously approved these changes
Apr 15, 2023
Contributor
frankhinek
left a comment
frankhinek
left a comment
There was a problem hiding this comment.
LGTM based on the most recent changes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd of 3 PRs to implement sync foundations. preceded by #290
Introduces an
EventsGetmessage to retrieve events. Still working on tests forEventsGetHandlerbut i wanted to kick off the review process because it can be lengthy. I imagine there will be some discussion aroundMessageReply.The PR that follows this one will introduce the
MessagesGetinterface method