-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump docker-compose to v2.25.0 #5939
Conversation
Download the artifacts for this pull request:
See Testing a PR |
Wow, completely 100% failed! |
It seems that the router is broken and is sending the request elsewhere? Maybe some labels are messed up or something.
I think the router is probably trying to hit itself? With v1.22.7 I get |
It works fine with docker-compose v2.24.6. But nothing at all works with 2.24.7. Unless it's the networks change in https://github.com/docker/compose/releases/tag/v2.24.7 I don't know what it would be. git bisect may be the path to study it (of compose). Or just wait for issues to show up in their queue? |
I tested commits for v2.24.7 docker-compose release. The bug is somewhere in: |
Thanks for the research! I think it's actually breaking something about ddev-router/traefik usage. |
Yes, found a bug report for this exact problem 😅: |
Compared the contents of v2.24.5: networks:
ddev_default:
external: true
name: ddev_default v2.24.7 networks:
ddev_default:
external: true
name: ddev_default
default:
name: ddev-d10_default and when you start another project: networks:
ddev_default:
external: true
name: ddev_default
default:
name: ddev-project_default |
Thanks for the great chasing @stasadev Closing this one for now, we'll watch |
Reopening with rebase and trying to fix our code for docker-compose v2.24.7 |
1eb8a9c
to
f4052fc
Compare
There is still a bug with the |
It still doesn't work because I made changes in only one place, the fix for the output should be made in: ddev/pkg/ddevapp/compose_yaml.go Line 76 in a4bf20b
|
f4052fc
to
540c614
Compare
540c614
to
695e963
Compare
I guess we should go ahead and go with this? Or should we try to adopt their new format at this time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should update docker-compose to v2.25.0.
The Issue
docker-compose v2.25.0 was released. Run tests on it.