Conversation
…ixes #22 ## The Issue The add-on failed to parse Upsun configurations using the official pattern where relationship values reference service names (e.g., mariadb: 'db:mysql'). Only non-standard configurations where the service name matched the database type worked by accident. ## How This PR Solves The Issue Updated UpsunConfigParser::getDatabaseConfig() to parse relationship string format 'service_name:endpoint' by extracting the service name and looking it up in the services configuration, matching the pattern already implemented in FixedConfigParser. This handles the official Upsun pattern while maintaining backward compatibility with existing configurations. Also added trim() to Redis config parser for consistency. ## Automated Testing Overview Added new test fixture mariadb-generic-flex that uses generic service name 'db' instead of 'mariadb', and added corresponding test case to drupal11-unified.bats. All existing tests continue to pass, verifying backward compatibility. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
rfay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
The add-on failed to parse Upsun configurations using the official pattern where relationship values reference service names (e.g., mariadb: 'db:mysql'). Only non-standard configurations where the service name matched the database type worked by accident.
How This PR Solves The Issue
Updated UpsunConfigParser::getDatabaseConfig() to parse relationship string format 'service_name:endpoint' by extracting the service name and looking it up in the services configuration, matching the pattern already implemented in FixedConfigParser. This handles the official Upsun pattern while maintaining backward compatibility with existing configurations.
Also added trim() to Redis config parser for consistency.
Manual Testing Instructions
Automated Testing Overview
Added new test fixture mariadb-generic-flex that uses generic service name 'db' instead of 'mariadb', and added corresponding test case to drupal11-unified.bats. All existing tests continue to pass, verifying backward compatibility.