Fix shape mismatch error during backpropagation in MLP optimizer #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This submission addresses the issue tracked in #78.
Root Cause
In optimizers like Adam and SGD, the
self.cache
was shared among all layers, leading to a situation where the cache keys were simplyW
andb
. As a result, when different layers attempted to update their parameters, they all referred to the same cache entries. This led to shape mismatches because the updates for different layers were not properly isolated.For instance, the cache should have unique keys like
layer1-W
,layer1-b
,layer2-W
, etc., but instead, all parameters were using the same keys, resulting in conflicts during backpropagation.Solution
The solution involved ensuring that each layer maintained its own cache. This was done by creating a deepcopy of the optimizer linked to each specific layer during its initialization. This way, each layer could independently manage its cache.
All Submissions
Changes to Existing Models