Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create gaussian_discriminant_analysis.py #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create gaussian_discriminant_analysis.py #19

wants to merge 1 commit into from

Conversation

Christakou
Copy link

A framework for building general discriminant analysis models, currently implemented quadratic discriminant analysis, will later add support for linear discriminant analysis too.

@@ -0,0 +1,45 @@
import numpy as np
import pandas as pd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you did not use pandas package in your code. So I think you could remove this line.

@WuZhuoran
Copy link
Contributor

WuZhuoran commented Jul 11, 2019

Could you please create unit test for this?

Maybe you can refer sklearn-test for details.

@ddbourgin
Copy link
Owner

ddbourgin commented Jul 13, 2019

Hi @Christakou - thanks for the submission! A few general comments:

  1. I notice your code relies on the pandas library. In order to be consistent with the rest of the codebase, you should modify the model to expect numpy arrays instead - no pandas allowed :)
  2. In order to demonstrate your code is sound, please include unit tests against an existing implementation of the model. sklearn's DiscriminantAnalysis module looks like it might be relevant here.
  3. Please include brief documentation in the NumPy style for the public methods in your model.
  4. Style: as much as possible, try to follow pep8 style conventions (e.g., camel_case for method, function, and variable names) to ensure readability. You can autoformat your code with the online Black formatter

You can see the general contribution guidelines here. Let me know if you have questions !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants