Fix bug on appearances scraping (#273)

dcaribou · Jan 10, 2024 · af1440f · af1440f
1 parent 1131fc7
commit af1440f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/.github/workflows/acquire-transfermarkt-scraper.yml b/.github/workflows/acquire-transfermarkt-scraper.yml
@@ -141,6 +141,8 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
+          # a different (personal access) github token need to be setup here so that a 'add-and-commit' step below triggers the 'on-push' workflow
+          # checkout https://github.community/t/push-from-action-does-not-trigger-subsequent-action/16854
           token: ${{ secrets.PA_GITHUB_TOKEN }}
       - name: pull data
         run: |

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -25,6 +25,7 @@ jobs:
 
       - name: Run tests
         run: |
+          set -e
           make dvc_pull test prepare_local DBT_TARGET=prod
           dvc commit -f
           git config --global --add safe.directory '*'

diff --git a/dbt/models/curated/models.yml b/dbt/models/curated/models.yml
@@ -184,7 +184,7 @@ models:
             - player_club_domestic_competition_id
       - dbt_expectations.expect_table_row_count_to_be_between:
           min_value: 430000
-          max_value: 460000
+          max_value: 480000
     columns:
       - name: player_id
         tests:

diff --git a/poetry.lock b/poetry.lock