Allow dbt show and dbt compile to output JSON without extra logs
#9958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenyuLInx
reviewed
May 16, 2024
| fire_event(compiled_node_event) | ||
| else: | ||
| # Cleaner to leave as print than to mutate the logger not to print timestamps. | ||
| print(compiled_node_event.message()) |
There was a problem hiding this comment.
We can use the new PrintEvent being added to dbt-common.
There was a problem hiding this comment.
Awesome! I'll check out dbt-labs/dbt-common#130 and give PrintEvent a try.
There was a problem hiding this comment.
Note to self: see #10131 for an example how to use PrintEvent.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9840
Problem
As described in #9840:
dbt listuses the--quietflag to isolate the desired output from the log output, allowing the results to be piped or redirected.But currently,
dbt showanddbt compileto not work similarly.Solution
Adopt the same exact approach as
dbt listhere, and basically copy-paste the code it uses.Checklist