Skip to content

Add description/columns to ModelNodeArgs so that plugins ingest description/columns to manifest.json #11553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

toukoudo
Copy link

Resolves #11527

Problem

  • As far as I know, currently, plugins cannot ingest document/column information for external nodes, resulting in no descriptions or column details appearing in manifest.json for these nodes
  • I would like to be able to see description and column information for plugin-ingested nodes in the manifest output

Solution

  • Add columns/description fields to ModelNodeArgs so that plugins can ingest them

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@toukoudo toukoudo requested a review from a team as a code owner April 29, 2025 05:26
Copy link

cla-bot bot commented Apr 29, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @toukoudo

@github-actions github-actions bot added the community This PR is from a community member label Apr 29, 2025
@toukoudo
Copy link
Author

I submitted the form! @cla-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow a plugin to ingest the model description and columns to externalNode/manifest.json
1 participant