Skip to content

feat: add TCP keepalive configuration for Redshift connections [DRAFT] #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

luis-garza-dev
Copy link

@luis-garza-dev luis-garza-dev commented Jun 11, 2025

resolves #
docs dbt-labs/docs.getdbt.com/#
aws/amazon-redshift-python-driver#252 (comment)

Problem

Customers report an intermittent issue where long-running CREATE TABLE queries (20+ minutes) appear to hang in DBT, while showing as "Completed" in AWS Console. However, the tables aren't actually created, leading to customer confusion and reduced trust in the product.

Solution

  • Add configuration for TCP keepalive parameters in the driver - set a default value while allowing customers to override it via connection properties
  • Will allow DBT to detect lost connections quickly
  • Command will fail with an error message instead of hanging
  • While query will still show as "Completed" in console, users will get prompt feedback about connection failure

Note: This change depends on change on Redshift driver to support TCP keepalive properties.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

TODO

  • Finalize Redshift driver version (required for compatibility)
  • Add unit tests as needed

@luis-garza-dev luis-garza-dev requested a review from a team as a code owner June 11, 2025 17:18
Copy link

cla-bot bot commented Jun 11, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Luis Garza.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Jun 25, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Luis Garza.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Jul 9, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Luis Garza.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@colin-rogers-dbt
Copy link
Contributor

@luis-garza-dev going to take this over to add some testing in #1194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants