Replace certifi upper version constraint with inequality #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's pretty important to keep CAs up-to-date, so this definitely isn't sustainable. People may pin the current version of `dbt-snowflake` without noticing the `certifi` upper-bound, and as a result they will eventually end up with connection issues and/or not recognizing revoked certificates.
|
Thank you for your pull request! We could not find a changelog entry for this change in the dbt-snowflake package. For details on how to document a change, see the Contributing Guide. |
3 tasks
lpillmann
pushed a commit
to lpillmann/dbt-adapters
that referenced
this pull request
May 6, 2025
* lazy load agate * Add test and documentation. * Fix test. * Fix test. * Don't need a test for this. --------- Co-authored-by: dwreeves <[email protected]> Co-authored-by: Mila Page <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1036, improving on #1027
Problem
It's pretty important to keep CAs up-to-date, so the current upper bound definitely isn't sustainable. People may pin the current version of
dbt-snowflakewithout noticing thecertifiupper-bound, and as a result they will eventually end up with connection issues and/or not recognizing revoked certificates.Solution
Replace
<with!=to block only the problematic version and not future versions.Checklist