Mostly complete conversion to 4.2.2 #188

menaechmi · 2024-03-13T18:44:54Z

I'm re-writing this description, because the status has changed dramatically since it was first written.

Tests

Two test currently fail:

tests/integration/test_manipulation_buttons.gd.TestManipulationButtons fails with
[VECTOR2(203.93003845214843750000, 401.15228271484375000000)] expected to equal [VECTOR2(103, -240.5)] +/- [(2, 2)]: Card focused and in correct global position at line 17

The cards don't even have manipulation buttons in this nor when I tested it in 3.x so I didn't try to fix it.

tests/integration/test_piles.gd.TestPopupView test_popup_deck_viewfails with
[true] expected to equal [false]: Cards returning from popup should respect piles card facing at line 141

It fails because cards can't be dragged in the PopupView for some reason. Fix that, and the test should pass.

Fonts/Labels

Text and labels in CardFront.gd need to be fixed. (Basically all text on cards doesn't fit)
The project (in the project.godot) is currently named "(new)Card Game Framework". It should be renamed to "Card Game Framework", but when this happens the whole framework slows down and a bunch of errors start popping up. Most of them are in CardFront.gd and are because a node can't get_tree() to wait for a process frame when it's not in the scene tree yet. But even without those errors, the whole framework slows to a crawl when that happens and almost every tween stops working. I'm pretty sure it's related to a lack of awaits in CardFront.gd or similar - but I did not track down why a name change triggers it.
The focus dupes are a little weird still. The card in the focus dupe is 1.5x the size, but the surrounding control is another 1.5x larger, so you get a 1.5x focus dupe with a 2.25x box around it. It's caused because the control's original size is saved AFTER the card is resized to current size * 1.5 scale. But resizing the card also resizes the control, so later when the control is scaled to size * 1.5 scale, it gets doubled.
Tags in a focus dupe don't line break
Text on the back of of cards extends past the card edge.

Demo scenes

Basically everything works

The box where you can pick Scaling Focus etc is never populated.
In the Main Menu the Tests/GUT option should be removed
CardLibrary and DeckBuilder are functional, but the scenes don't show up correctly - I haven't looked into why.

CI

The mouse doesn't work well in github CI, so more tests fail. Probably moving from mouse movement to functions like move_to will work better, but there are times where that can't happen.
The junit output reader I added to the CI doesn't seem to work well with the gut output, so it should probably be dropped

Basically everything works and because it works in 4.2.2, it should work in versions all through 4.4.1 (but I haven't extensively tested it).

Everything else I would do is a major refactor, so if I continue it it will be as a separate fork.

Made some edits based on experience of following this tutorial in v3.5.1 of Godot. I was able to complete the tutorial from start to finish, and end up with a working version of the sandbox with a deck containing the two custom cards that I could draw from.

Small change to say updated for 3.5.3 rather than 3.5.1 as originally stated.

Update QUICKSTART.md

not yet 100%. see pull request for details

fix from godot-tester issue 36

From: https://github.com/github/gitignore/blob/6eeebe6f49678aacd8311ce079842c971b3ebe96/Godot.gitignore Need to add the .godot folder since it's full of cooked assets. We also now include *.import files as recommended in the docs: https://docs.godotengine.org/en/4.3/tutorials/assets_pipeline/import_process.html#files-generated

Not using any custom settings. Just the defaults. I'm doing this on Godot 4.3. Not sure if that matters.

Fix a ton of gut errors: scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/RunAtCursor.tscn:4 - ext_resource, invalid UID: uid://cr6tvdv0ve6cv - using text path instead: res://addons/gut/gui/play.png scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/RunAtCursor.tscn:5 - ext_resource, invalid UID: uid://6wra5rxmfsrl - using text path instead: res://addons/gut/gui/arrow.png scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/GutBottomPanel.tscn:6 - ext_resource, invalid UID: uid://cr6tvdv0ve6cv - using text path instead: res://addons/gut/gui/play.png scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/GutBottomPanel.tscn:7 - ext_resource, invalid UID: uid://4gyyn12um08h - using text path instead: res://addons/gut/gui/RunResults.tscn || Cannot open file 'res://addons/gut/gui/RunResults.tscn'. || Failed loading resource: res://addons/gut/gui/RunResults.tscn. Make sure resources have been imported by opening the project in the editor at least once. res://addons/gut/gut_plugin.gd|8| Attempt to call function 'create_temp_directory' in base 'null instance' on a null instance. res://addons/gut/gut.gd|1| Parse Error: Could not resolve super class path "res://addons/gut/gut_to_move.gd". res://addons/gut/gui/BottomPanelShortcuts.gd|5| Invalid access to property or key 'editor_shortcuts_path' on a base object of type 'null instance'. res://addons/gut/gui/GutBottomPanel.gd|21| Invalid call. Nonexistent function 'get_rich_text_edit' in base 'MissingNode'. res://addons/gut/gui/GutBottomPanel.gd|52| Attempt to call function 'create_temp_directory' in base 'null instance' on a null instance. res://addons/gut/gui/GutBottomPanel.gd|317| Invalid access to property or key 'run_results' on a base object of type 'Nil'. res://addons/gut/gui/GutBottomPanel.gd|99| Invalid access to property or key 'shortcut_dialog' on a base object of type 'Nil'. Checked out gut tag v9.3.0 and replaced our addons/gut/ folder with their addons/gut/ folder. When running, gut tells us it's copying our config to use as a template, but I don't think we want to delete the template because all repo devs should use it: || GUT Info: Copying [res://.gut_editor_config.json] to [user://gut_temp_directory/gut_editor_config.json] || GUT Warning: File [res://.gut_editor_config.json] has been moved to [user://gut_temp_directory/gut_editor_config.json]. || You can delete res://.gut_editor_config.json || GUT Info: Copying [res://.gut_editor_shortcuts.cfg] to [user://gut_temp_directory/gut_editor_shortcuts.cfg] || GUT Warning: File [res://.gut_editor_shortcuts.cfg] has been moved to [user://gut_temp_directory/gut_editor_shortcuts.cfg]. || You can delete res://.gut_editor_shortcuts.cfg || GUT got some new images that are not imported yet. Please restart Godot. The Gut editor panel seems to work and I can run tests (they don't all pass).

Upgrade gut to v9.3.0, include `.import` files, update .gitignore

CardTemplate's _tween is a WeakRef and not a Tween. Also resets the project.godot to the compat renderer

db0 · 2025-06-23T17:58:48Z

Thanks for doing this. If you're still working on this, why not keep it as draft?

Not sure about manipulation_bottons, but only 29 failing remain

(Likely fixed when ScEng_common.gd was edited)

It doesn't work in the 3.x version, so it works the same amount here

This one fails in 3.x, it fails less in 4.2 now though

Fix tween logic, fix set/get

CardTemplate fix whitespace Pile change some tween awaits

Another one that doesn't work in 3.x but works in 4 now :)

delete old TODO/FIXME comments, fix a quick tween error

Also deletes the cli test scene, as it's no longer used

markp3rry and others added 19 commits February 18, 2024 12:01

Update QUICKSTART.md

03c70ac

Made some edits based on experience of following this tutorial in v3.5.1 of Godot. I was able to complete the tutorial from start to finish, and end up with a working version of the sandbox with a deck containing the two custom cards that I could draw from.

Update QUICKSTART.md

fec0c0a

Small change to say updated for 3.5.3 rather than 3.5.1 as originally stated.

Merge pull request db0#186 from markp3rry/patch-1

932414f

Update QUICKSTART.md

update to 4.0. all compile-time and most run-time errors solved.

b314af5

not yet 100%. see pull request for details

remerge update to quickstart.md

af1df15

Futher 3->4 fixes. Most tests can complete, even if they do not pass

a525aaa

Change github actions to 4.2.1 gut tester

8d2ae69

Create test_results.xml

0e535e7

output-file doesn't always work

b55ed70

fix from godot-tester issue 36

Update gut.yml

3dc7da0

Update gut.yml

a3d8f5f

change gut.yml to godot-gut-ci

0fd13ec

Update gut.yml

71e2535

Update gut.yml

6310632

Add *.import files

08ce068

Not using any custom settings. Just the defaults. I'm doing this on Godot 4.3. Not sure if that matters.

Merge pull request #3 from idbrii/gut-930

dcbc810

Upgrade gut to v9.3.0, include `.import` files, update .gitignore

Use get_ref before accessing card tweens (#4)

9287085

CardTemplate's _tween is a WeakRef and not a Tween. Also resets the project.godot to the compat renderer

menaechmi force-pushed the conversion branch from 6faf31a to 9287085 Compare June 23, 2025 17:32

menaechmi added 2 commits June 23, 2025 13:06

button.pressed -> button.button_pressed

a8ef3da

change uid of font

96a2ef9

menaechmi marked this pull request as draft June 23, 2025 18:30

menaechmi added 6 commits June 23, 2025 17:44

Fix card class unit tests

9b395b7

idle_frame is process_frame

a78810e

fix a few more if_tween()

ef0f554

remove AskInteger test

5353446

fix cardcontainer tests

0ae10ce

implement WeakRef tweens for CardContainers + Piles

0a96099

menaechmi added 28 commits July 15, 2025 16:58

[Tests] Fix unit test timing

6a00846

[Tests] scripting_engine_subjects

21293d3

[Tests] Fix test_card_index

677422b

[Tests] Fix test_mouse_pointer

10665f3

[Tests] Add offset to drag_card()

76d6862

[Tests] fix test piles

3670d3f

Not sure about manipulation_bottons, but only 29 failing remain

[Tests] Fix scripting_engine_filters

c0fa40c

[Tests] fix test_scripting_engine_costs

75d10e4

(Likely fixed when ScEng_common.gd was edited)

[Tests] Fix test_attachments

8fb6f24

It doesn't work in the 3.x version, so it works the same amount here

[Tests] Fix test_board_use

7ae55b2

[Tests] Fix test_mouse_pointer

c2c1e79

[Tests] Fix test_scaling_focus

9b5ea42

[Tests] Fix test_placement_grid

4b81c9c

[Core][Tests] fix test_scripting_engine_signals

ad901c2

[Tests] Fix test_scripting_engine_tasks

4259be2

[Tests] fix test_targetting

9c252a1

This one fails in 3.x, it fails less in 4.2 now though

[Core] Enable TokenDrawer

c5e9db4

Fix tween logic, fix set/get

[Tests] Fix test_tokens

e19c838

[Core] TargetingArrow fix out of index error

099b70d

CardTemplate fix whitespace Pile change some tween awaits

[Tests] Fix test_targetting

d694842

CardTemplate: Remove call deferred, as -> is

207e3ec

[Tests] Fix test_viewport_focus

228658e

Another one that doesn't work in 3.x but works in 4 now :)

[Tests] fix test_reshuffle_all

7da531f

[Core] Some tween cleanup

82b81ef

[Tests] Fix remaining tests (more or less)

d32d420

Cleanup a few last things

6acfd62

delete old TODO/FIXME comments, fix a quick tween error

Reimport and change renderer

9ee7555

Also deletes the cli test scene, as it's no longer used

Add some final comments on font

5baf68b

menaechmi changed the title ~~Mostly complete conversion to 4.2.1~~ Mostly complete conversion to 4.2.2 Jul 18, 2025

menaechmi marked this pull request as ready for review July 18, 2025 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Mostly complete conversion to 4.2.2 #188

Mostly complete conversion to 4.2.2 #188

Uh oh!

menaechmi commented Mar 13, 2024 •

edited

Loading

Uh oh!

db0 commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

Mostly complete conversion to 4.2.2 #188

Are you sure you want to change the base?

Mostly complete conversion to 4.2.2 #188

Uh oh!

Conversation

menaechmi commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests

Fonts/Labels

Demo scenes

CI

Uh oh!

db0 commented Jun 23, 2025

Uh oh!

Uh oh!

menaechmi commented Mar 13, 2024 •

edited

Loading