Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(xo): removed ignores #3761

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(xo): removed ignores #3761

wants to merge 1 commit into from

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Feb 1, 2025

we shouldn't ignore xo in general. xo is here to hurt our feelings. If it does, that's a good thing.

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke
refactor(xo): removed ignores
49ac1a7 
we shouldn't ignore `xo` in general. `xo` is here to hurt our feelings. If it does, that's a good thing.
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Feb 1, 2025
@mfranzke mfranzke self-assigned this Feb 1, 2025
@mfranzke mfranzke marked this pull request as draft February 1, 2025 13:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-removed-xo-ignores

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfranzke