Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: write test for required inputs to read messages #2906

Merged
merged 32 commits into from
Aug 14, 2024
Merged

test: write test for required inputs to read messages #2906

merged 32 commits into from
Aug 14, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Jul 24, 2024 •
edited
Loading

Proposed changes

closes #2624
closes #2625

Because of the changes in aria-describedby the screen reader already announces changes coming from the valid/invalid messages.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/test-input-required-messages

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Jul 24, 2024
@nmerget nmerget enabled auto-merge (squash) July 24, 2024 13:47
mfranzke
mfranzke previously approved these changes Jul 25, 2024
View reviewed changes
@nmerget nmerget marked this pull request as draft July 25, 2024 06:31
auto-merge was automatically disabled July 25, 2024 06:31

Pull request was converted to draft

@github-actions github-actions bot added the 🏘components Changes inside components folder label Jul 25, 2024
@nmerget nmerget marked this pull request as ready for review July 25, 2024 14:53
@nmerget nmerget enabled auto-merge (squash) July 25, 2024 14:53
@nmerget nmerget requested a review from mfranzke July 25, 2024 14:53
@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Jul 26, 2024
@nmerget nmerget requested a review from mfranzke July 26, 2024 13:35
@mfranzke mfranzke self-assigned this Jul 31, 2024
@mfranzke mfranzke mentioned this pull request Aug 14, 2024
Open
mfranzke
mfranzke previously approved these changes Aug 14, 2024
View reviewed changes
@nmerget nmerget requested a review from mfranzke August 14, 2024 08:09
mfranzke
mfranzke previously approved these changes Aug 14, 2024
View reviewed changes
@nmerget nmerget requested a review from mfranzke August 14, 2024 12:37
@nmerget nmerget merged commit d84aa39 into main Aug 14, 2024
61 checks passed
@nmerget nmerget deleted the test-input-required-messages branch August 14, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees

@mfranzke mfranzke

Labels
🏘components Changes inside components folder 🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
2 participants
@nmerget @mfranzke