Skip to content

Commit

Permalink
chore: removed lts angular showcase to reduce complexity (#2841)
Browse files Browse the repository at this point in the history
* chore: removed lts angular showcase to reduce complexity

* chore: removed lts angular showcase to reduce complexity

* chore: remove remaining angular-lts stuff

* chore: update from main
  • Loading branch information
nmerget authored Nov 5, 2024
1 parent 7b0e227 commit 9061cd7
Show file tree
Hide file tree
Showing 99 changed files with 1,459 additions and 8,762 deletions.
85 changes: 0 additions & 85 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,88 +113,3 @@ updates:
update-types:
- 'minor'
- 'patch'

- package-ecosystem: 'npm'
directory: '/showcase/angular-active-showcase'
open-pull-requests-limit: 10
schedule:
interval: 'daily'
time: '04:00'
timezone: 'Europe/Berlin'
ignore:
- dependency-name: 'ng-packagr'
update-types: ['version-update:semver-major']
# Especially as we're using multiple major versions of Angular, we want to update the major version by ourselves
- dependency-name: '@angular/cli'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/core'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/compiler-cli'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/router'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/compiler'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/common'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/forms'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/platform-browser-dynamic'
update-types: ['version-update:semver-major']
- dependency-name: '@angular-devkit/build-angular'
update-types: ['version-update:semver-major']
pull-request-branch-name:
separator: '-'
groups:
angular:
patterns:
- '@angular*'
- '@angular-devkit*'
- 'ng-packagr'
update-types:
- 'minor'
- 'patch'

- package-ecosystem: 'npm'
directory: '/showcase/angular-lts-showcase'
open-pull-requests-limit: 10
schedule:
interval: 'daily'
time: '04:00'
timezone: 'Europe/Berlin'
ignore:
- dependency-name: 'ng-packagr'
update-types: ['version-update:semver-major']
# Especially as we're using multiple major versions of Angular, we want to update the major version by ourselves
- dependency-name: '@angular/cli'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/core'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/compiler'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/compiler-cli'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/router'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/common'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/forms'
update-types: ['version-update:semver-major']
- dependency-name: '@angular/platform-browser-dynamic'
update-types: ['version-update:semver-major']
- dependency-name: '@angular-devkit/build-angular'
update-types: ['version-update:semver-major']
# Angular 15 only works with zone.js 0.13.x
- dependency-name: 'zone.js'
update-types: ['version-update:semver-minor']
pull-request-branch-name:
separator: '-'
groups:
angular:
patterns:
- '@angular*'
- '@angular-devkit*'
- 'ng-packagr'
update-types:
- 'minor'
- 'patch'
11 changes: 3 additions & 8 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,10 @@ vue:
- changed-files:
- any-glob-to-any-file: 'packages/db-ui-elements-vue/**'

# Add 'angular-active-showcase' label to any file changes for angular-active-showcase
angular-active-showcase:
# Add 'angular-showcase' label to any file changes for angular-showcase
angular-showcase:
- changed-files:
- any-glob-to-any-file: 'showcase/angular-active-showcase/**'

# Add 'angular-lts-showcase' label to any file changes for angular-lts-showcase
angular-lts-showcase:
- changed-files:
- any-glob-to-any-file: 'showcase/angular-lts-showcase/**'
- any-glob-to-any-file: 'showcase/angular-showcase/**'

# Add 'playground-showcase' label to any file changes for playground-showcase
playground-showcase:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/01-build-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- name: 👩‍🍳 Bake everything (StoryBook, Playground & Showcases)
run: |
node scripts/build angular-active,angular-lts,react,vue,playground,reactwind withShowcase
node scripts/build angular,react,vue,playground,reactwind withShowcase
npm run build:storybook
- name: ⬆ Upload build
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/01-build-showcases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
showcases:
[angular-active, angular-lts, playground, react, reactwind, vue]
[angular, playground, react, reactwind, vue]
steps:
- name: ⬇ Checkout repo
uses: actions/checkout@v4
Expand All @@ -22,10 +22,7 @@ jobs:

- name: ↔ Get download params for showcase
run: |
if echo ${{ matrix.showcases }} | grep -c "angular-active"
then
echo "framework=angular" >> $GITHUB_OUTPUT
elif echo ${{ matrix.showcases }} | grep -c "angular-lts"
if echo ${{ matrix.showcases }} | grep -c "angular"
then
echo "framework=angular" >> $GITHUB_OUTPUT
elif echo ${{ matrix.showcases }} | grep -c "playground"
Expand Down
15 changes: 4 additions & 11 deletions .github/workflows/01-build-storybook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,11 @@ jobs:
name: stencil-default-angular
path: packages/db-ui-elements-stencil

- name: ⬇ Download Showcase Angular active dist folder
- name: ⬇ Download Showcase Angular dist folder
uses: actions/download-artifact@v4
with:
name: showcase-angular-active
path: showcase/angular-active-showcase/dist

- name: ⬇ Download Showcase Angular LTS dist folder
uses: actions/download-artifact@v4
with:
name: showcase-angular-lts
path: showcase/angular-lts-showcase/dist
name: showcase-angular
path: showcase/angular-showcase/dist

- name: ⬇ Download Showcase playground dist folder
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -67,8 +61,7 @@ jobs:
env:
VERSION: ${{ inputs.tag }}
run: |
mv showcase/angular-lts-showcase/dist/angular-lts-showcase packages/db-ui-elements-stencil/www/angular-lts-showcase
mv showcase/angular-active-showcase/dist/angular-active-showcase packages/db-ui-elements-stencil/www/angular-active-showcase
mv showcase/angular-showcase/dist/angular-showcase packages/db-ui-elements-stencil/www/angular-showcase
mv showcase/playground-showcase/dist/playground-showcase packages/db-ui-elements-stencil/www/playground-showcase
mv showcase/react-showcase/dist/react-showcase packages/db-ui-elements-stencil/www/react-showcase
mv showcase/reactwind-showcase/dist/reactwind-showcase packages/db-ui-elements-stencil/www/reactwind-showcase
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ If you miss a component than [contribute](CONTRIBUTING.md), please.
## Framework showcases

* [DB UI Elements with React (CRA)](showcase/react-showcase/README.md)
* [DB UI Elements with Angular 18](showcase/angular-active-showcase/README.md)
* [DB UI Elements with Angular 17](showcase/angular-lts-showcase/README.md)
* [DB UI Elements with Angular 18](showcase/angular-showcase/README.md)
* [DB UI Elements with Vue](showcase/vue-showcase/README.md)

## Deutsche Bahn brand
Expand Down
7 changes: 2 additions & 5 deletions doc/howto-angular.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,5 @@ There are 3 ways to use Events in Angular:

### Example

[Angular v.18 Showcase GitHub](https://github.com/db-ui/elements/tree/main/showcase/angular-active-showcase)
[Angular v.18 Showcase App](https://db-ui.github.io/elements/angular-active-showcase/)

[Angular v.17 Showcase GitHub](https://github.com/db-ui/elements/tree/main/showcase/angular-lts-showcase)
[Angular v.17 Showcase App](https://db-ui.github.io/elements/angular-lts-showcase/)
[Angular v.18 Showcase GitHub](https://github.com/db-ui/elements/tree/main/showcase/angular-showcase)
[Angular v.18 Showcase App](https://db-ui.github.io/elements/angular-showcase/)
2 changes: 1 addition & 1 deletion e2e/cypress/e2e/99-1-showcases/showcases-tables.cy.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
context('showcase', () => {
const showcases = ['angular-active', 'angular-lts'];
const showcases = ['angular'];

showcases.forEach((showcase) => {
it(`${showcase}: Test Tables`, () => {
Expand Down
2 changes: 1 addition & 1 deletion e2e/cypress/fixtures/showcases.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
["angular-active", "angular-lts", "react", "vue"]
["angular", "react", "vue"]
Loading

0 comments on commit 9061cd7

Please sign in to comment.